Skip to content

Address memory exhaustion errors within performance testing workflow#11930

Closed
desrosj wants to merge 6 commits into
WordPress:trunkfrom
desrosj:fix/performance-testing-exhaustion
Closed

Address memory exhaustion errors within performance testing workflow#11930
desrosj wants to merge 6 commits into
WordPress:trunkfrom
desrosj:fix/performance-testing-exhaustion

Conversation

@desrosj
Copy link
Copy Markdown
Member

@desrosj desrosj commented May 21, 2026

This attempts to address memory exhaustion errors that have been happening any time the BASE_TAG within the performance testing workflow is set to any value higher than 6.7.0 by downloading the needed version of WordPress using WP-CLI inside the GitHub Actions runner instead of within the Docker environment.

Trac ticket: Core-65289.

Use of AI Tools

None


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this May 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, swissspidy, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Comment thread .github/workflows/reusable-performance-test-v2.yml Fixed
Comment thread .github/workflows/reusable-performance-test-v2.yml Fixed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the reusable performance testing workflow to avoid memory exhaustion when running baseline (subject: base) measurements against WordPress versions newer than 6.7.0 by downloading the baseline WordPress version using WP‑CLI on the GitHub Actions runner (instead of invoking WP‑CLI inside the Docker environment).

Changes:

  • Adds a conditional setup-php step (base-only) to install WP‑CLI on the runner.
  • Replaces npm run env:cli -- core download ... with a direct wp core download ... call for the baseline setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/reusable-performance-test-v2.yml Outdated
Comment thread .github/workflows/reusable-performance-test-v2.yml
@desrosj desrosj force-pushed the fix/performance-testing-exhaustion branch from 27e0a21 to b605216 Compare May 21, 2026 16:52
Copy link
Copy Markdown
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62406
GitHub commit: 207702c

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants